I'm not sure if netdev is the right list to post problems in
this driver to, but here we go...

Subject: rt2x00core: fix mismatched rwsem calls

 rt2x00_update_config pairs a down_write with an up_read call
 on the same semaphore.

 Similarly, rt2x00_link_down pairs a down_read call with an
 up_write call.

Signed-off-by: Olaf Kirch <[EMAIL PROTECTED]>

 rt2x00core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Index: rt2x00-2.0.0-b3/rt2x00core.c
===================================================================
--- rt2x00-2.0.0-b3.orig/rt2x00core.c
+++ rt2x00-2.0.0-b3/rt2x00core.c
@@ -93,7 +93,7 @@ rt2x00_update_config(struct _rt2x00_devi
        if(likely(update_flags))
                device->handler->dev_update_config(device, &core->config, 
update_flags);
 
-       up_read(&device->rt2x00_sem);
+       up_write(&device->rt2x00_sem);
 
        clear_bit(DEVICE_CONFIG_UPDATE, &device->flags);
 }
@@ -1709,7 +1709,7 @@ rt2x00_link_down(struct _rt2x00_device *
                dev_set_promiscuity(device->net_dev, -1);
        }
 
-       up_write(&device->rt2x00_sem);
+       up_read(&device->rt2x00_sem);
 
        rt2x00_disconnect(device);
 

-- 
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
[EMAIL PROTECTED] |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to