On 64 bit platform MAX_SCHEDULE_TIMEOUT is 64 bits, so sparse throws
a warning on the check in the blink code. Just recode to a simpler version.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- pro-2.6.orig/drivers/net/skge.c
+++ pro-2.6/drivers/net/skge.c
@@ -57,7 +57,6 @@
#define ETH_JUMBO_MTU 9000
#define TX_WATCHDOG (5 * HZ)
#define NAPI_WEIGHT 64
-#define BLINK_MS 250
MODULE_DESCRIPTION("SysKonnect Gigabit Ethernet driver");
MODULE_AUTHOR("Stephen Hemminger <[EMAIL PROTECTED]>");
@@ -670,21 +669,15 @@ static void skge_led(struct skge_port *s
static int skge_phys_id(struct net_device *dev, u32 data)
{
struct skge_port *skge = netdev_priv(dev);
- unsigned long ms;
enum led_mode mode = LED_MODE_TST;
+ unsigned i;
- if (!data || data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ))
- ms = jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT / HZ) * 1000;
- else
- ms = data * 1000;
-
- while (ms > 0) {
+ for (i = 0; i < data * 2; i++) {
skge_led(skge, mode);
mode ^= LED_MODE_TST;
- if (msleep_interruptible(BLINK_MS))
+ if (msleep_interruptible(500))
break;
- ms -= BLINK_MS;
}
/* back to regular LED state */
--
Stephen Hemminger <[EMAIL PROTECTED]>
OSDL http://developer.osdl.org/~shemminger
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
