Jeff Kirsher wrote:
Fix jumbo frame performance
Partition PBA for Jumbo frames based on MTU size.
Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]>
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
nooooooo ;-) ;-)
The patch content looks good, but two process problems:
Problem 1) Test application of the very first patch fails:
[EMAIL PROTECTED] netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.
Applying 'e1000: Fix jumbo frame performance'
error: patch failed: drivers/net/e1000/e1000_main.c:43
error: drivers/net/e1000/e1000_main.c: patch does not apply
Manual application with "patch -sp1 < mbox" succeeds, which means that
git(1) is once again being more strict than patch(1). /me grumbles in
the general direction of git developers... :)
Problem 2) You include the patch twice, once inline as a reviewable
patch (good), and once as a base64-encoded plaintext attachment (bad).
Please simply eliminate the attachment.
So, I am now faced with applying 39 patches by hand, manually pasting in
the changelog for each one, not something I am highly motivated to do.
We need to fix Intel's patch submission process to ensure that (a)
git-applymbox doesn't reject the patches, and (b) only a single copy of
each patch accompanies each email.
A highly recommended alternative would be to follow the example of James
Ketrenos(sp?) at Intel, who pushes ipw driver updates to me via git.
All you need is an http, rsync, or git server somewhere.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
