On Fri, 2006-01-13 at 18:09 +0100, Steffen Klassert wrote:
> ...
> > > I still have a patch in queue to improve usage of netif_carrier_{on,off} 
> > > but I had no possibility to test yet, so I did not send.
> > 
> > I'd be happy to test it out if you'd like.
> > 
> > Dan
> 
> Hi Dan,
> 
> here is the patch for testing.
> 
> 
> The patch _should_ do the following:
> 
> 1. Set the polling intervall for media changes to 5 seconds if link is down 
> and 60 seconds if link is up.
> 2. Handle netif_carrier_{on,of} and check for media changes in 
> proper way by using mii_check_media() in the mii case.
> 3. Handle netif_carrier_{on,of} also if media is forced to 10baseT/100baseTx.
> 4. Use ethtool_op_get_link instead of vortex_get_link. 
> So it is possible to test with ethtool.

The patch appears to work correctly and does notice links quite a bit
sooner.  The only issue I noticed was that if no cable is plugged in, it
starts off with the carrier on (/sys/class/net/eth0/carrier == "1") but
a second later switches the carrier off.  How do I track that down?

Dan

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to