On Wed, Jan 18, 2006 at 02:46:36AM +0100, Patrick McHardy wrote: > John W. Linville wrote: > >On Tue, Jan 17, 2006 at 07:17:55PM +0100, Roger While wrote: > > > >>I am going to NACK this. > >>Two reasons : > >>1) Unless we are patching different trees, it appears > >>the dev_kfree_skb at label drop_free got missed. > > > > > >http://marc.theaimsgroup.com/?l=linux-netdev&m=113629395408219&w=2 > > > >According to Patrick McHardy, the other dev_kfree_skb change is no > >longer required. Perhaps Patrick will comment? > > The second dev_kfree_skb is outside the interrupt-disabled > section, so using dev_kfree_skb is fine.
OK. So, do we want to change the dev_kfree_skb_irq to dev_kfree_skb_any? Anyone want to send a patch? John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
