From: Herbert Xu Sent: 1/20/2006 8:04:08 PM > Kris Katterjohn <[EMAIL PROTECTED]> wrote: > > This fixes some whitespace issues in af_packet.c > > > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> > > > > Thanks. > > > > --- x/net/packet/af_packet.c 2006-01-18 15:16:05.000000000 -0600 > > +++ y/net/packet/af_packet.c 2006-01-20 18:53:18.000000000 -0600 > > @@ -365,7 +365,7 @@ static int packet_sendmsg_spkt(struct ki > > */ > > > > err = -EMSGSIZE; > > - if(len>dev->mtu+dev->hard_header_len) > > + if(len>dev->mtu+dev->hard_header_len) > > How about add a space between "if" and "(" while you're at it? > > > - if (get_user(len,optlen)) > > - return -EFAULT; > > + if (get_user(len,optlen)) > > + return -EFAULT; > > Have a space after the comma please. >
Those changes and a couple more just like them. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> --- x/net/packet/af_packet.c 2006-01-21 00:01:53.000000000 -0600 +++ y/net/packet/af_packet.c 2006-01-21 00:01:04.000000000 -0600 @@ -365,7 +365,7 @@ static int packet_sendmsg_spkt(struct ki */ err = -EMSGSIZE; - if(len>dev->mtu+dev->hard_header_len) + if (len > dev->mtu + dev->hard_header_len) goto out_unlock; err = -ENOBUFS; @@ -935,7 +935,7 @@ static int packet_bind_spkt(struct socke * Check legality */ - if(addr_len!=sizeof(struct sockaddr)) + if (addr_len != sizeof(struct sockaddr)) return -EINVAL; strlcpy(name,uaddr->sa_data,sizeof(name)); @@ -1092,7 +1092,7 @@ static int packet_recvmsg(struct kiocb * * retries. */ - if(skb==NULL) + if (skb == NULL) goto out; /* @@ -1392,8 +1392,8 @@ static int packet_getsockopt(struct sock if (level != SOL_PACKET) return -ENOPROTOOPT; - if (get_user(len,optlen)) - return -EFAULT; + if (get_user(len, optlen)) + return -EFAULT; if (len < 0) return -EINVAL; @@ -1419,9 +1419,9 @@ static int packet_getsockopt(struct sock return -ENOPROTOOPT; } - if (put_user(len, optlen)) - return -EFAULT; - return 0; + if (put_user(len, optlen)) + return -EFAULT; + return 0; } - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html