Stephen Hemminger wrote:
On Thu, 26 Jan 2006 22:16:31 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Stephen Hemminger wrote:
The sky2 driver attempts to clear PCI express errors on boot, but
the PCI subsystem sometimes won't let the sky2 driver write to PCI
express registers. It depends on the phase of the moon
and number of goats sacrificed (actually it probably is ACPI).
Until the PCI subsystem is fixed, this patch uses the device iomem
window to access the PCI-Express related registers.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
patches 1-7 OK for upstream-fixes branch, but patch #1 failed to apply:
Applying 'sky2: pci express config register access'
fatal: corrupt patch at line 6
Andi has a fix for those busted BIOS's, so I am going to redo the patch
to just check for bad BIOS and punt.
Due to the immature state of PCI MSI, particularly the knowledge of when
MSI-capable cards should not enable MSI for system-related reasons, I
think applying patch #8 during 2.6.16-rc would not be appropriate.
How about a module parameter to disable it?
Preferred is code that will initiate a hardware interrupt from software.
If the interrupt isn't delivered, you know MSI isn't working. tg3
does this, IIRC. A module parameter is better than nothing.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
