From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 26 Jan 2006 13:42:02 +1100
> Eric W. Biederman <[EMAIL PROTECTED]> wrote:
> >
> > This patch fix dst reference counting in tcp_v6_send_synack
> >
> > Analysis:
> > Currently tcp_v6_send_synack is never called with a dst entry
> > so dst always comes in as NULL.
>
> Thanks for the bug fix. BTW, why don't we get rid of the dst
> argument to rtx_syn_ack altogether? As it is if we ever start
> using the dst argument these functions could break.
Aieee! This is one hairy area, and one ripe for audit :)
For example, dccp_v4_send_response() always releases the DST
yet dccp_v6_send_response() never does. Which one is correct?
Regardless, since everyone passes NULL as the dst argument
to ->rtx_syn_ack() I am going to kill that argument off now
before it causes any troubles and then put in Eric's fix
(after thinking about it some more).
Can someone check out the dccp_v{4,6}_send_response() cases and
sort them out?
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
