From: "David S. Miller" <[EMAIL PROTECTED]> Subject: Re: [PATCH] AF_PACKET: mmap compat support Date: Fri, 10 Feb 2006 02:53:42 -0800 (PST)
> > NACK. The 32bit test ifdefs are horrible. Please add fops->compat_mmap > > instead. > > is_compat_task() is going into asm-*/compat.h eventually anyways, so > ignore the ifdefs. > > They're only there because the interface isn't provided yet. > > I guess you haven't seen drivers/input/evdev.c where this same > set of ifdefs already exist. > > Anyways, adding a compat layer file operations method would be a nice > idea. But I think it might be a bit unreasonable that every person > trying to simply fix a bug is expected to go out and create entirely > new infrastructure. I will try if necessary. However, I'm not sure how fops->compat_mmap works in this case because we may need to put incoming packets in the ring buffer right after a process calls getsockopt(). - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
