Christoph Hellwig <[EMAIL PROTECTED]> : [...] > the about to rename part is really noisy.
Yes. @@ -730,7 +731,11 @@ int dev_change_name(struct net_device *d else if (__dev_get_by_name(newname)) return -EEXIST; else + { -> a cleanup patch may be avoided if the "{" follows the "else" + if (strncmp(newname, dev->name, IFNAMSIZ)) + printk(KERN_INFO "%s renamed to %s\n", dev->name, newname); -> I would rather do a quick return if (!strncmp(...)) (personnal taste). -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html