Evgeniy Polyakov wrote: > On Mon, Feb 20, 2006 at 02:49:41PM +0100, Patrick McHardy ([EMAIL PROTECTED]) > wrote: > >>Still netlink_has_listeners should not return an error. If no listeners >>exist, netlink_broadcast would return 0, netlink_has_listeners is just >>an optimization for that case. > > > Doesn't netlink_broadcast() return 0 only if skb was really delivered, i.e. > queued into at least one destination socket, when netlink_broadcast_deliver() > returns > boolean value 0 or 1 (atomic_read(&sk->sk_rmem_alloc) > sk->sk_rcvbuf)?
You're right, it returns -ESRCH when there were no listeners. In that case it makes sense of course to do the same if netlink_has_listeners returns 0. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
