On Wed, Feb 22, 2006 at 10:39:03AM +0200, Ilia Sotnikov wrote: > On 2/21/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > > Actually, here is a better patch for your problem. We should really > > be using the TOS when doing IPsec lookups: > > > > [IPSEC] Use TOS when doing tunnel lookups > > > > We should use the TOS because it's one of the routing keys. It also > > means that we update the correct routing cache entry when PMTU occurs. > > > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Not using TOS for hash calculation in the routing cache doesn't mean > that we will find incorrent routing cache entry - we could find such a > cached entry not using TOS, but when we compare its fields including > TOS with a packet's fields ip_route_input_slow() will do fib_lookup() > in case of false comparision result. As I wrote before, the patch > could only reduce number of routing cache hits. Am I wrong somewhere?
No you're quite right. However, this is not related to my patch which fixes a real bug in the IPsec code. The problem you raised is real and will be solved. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
