On Thu, 23 February 2006 19:28:49 +1100, Herbert Xu wrote: > On Thu, Feb 23, 2006 at 07:53:36AM +0100, J?rn Engel wrote: > > > > How is that argument special for kfree_skb? Both libc free and kfree > > ignore NULL arguments and do so for good reasons. > > Well with kfree there is actually a slight gain in that you are doing > the check in one place. > > kfree_skb on the other hand is inlined so the you're actually adding > bloat to many places that simply don't need it.
Wrt. the binary, you have a point. For source code, my patch does not any new bloat and allows removal of the existing. Lemme do a quick measurement for the kernel I run on my machine: -rwxr-xr-x 1 joern src 4836592 Feb 23 10:43 vmlinux -rwxr-xr-x 1 joern src 4836727 Feb 23 10:19 vmlinux.kfree_null 135 bytes added by my patch. Not that much. Jörn -- He who knows others is wise. He who knows himself is enlightened. -- Lao Tsu - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
