On Fri, 03 Mar 2006 18:59:12 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger wrote:
> > Eliminate stub, just call directly.
> >
> > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
> >
> > --- br-2.6.orig/net/bridge/br_input.c
> > +++ br-2.6/net/bridge/br_input.c
> > @@ -21,12 +21,6 @@
> >
> > const unsigned char bridge_ula[6] = { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x00 };
> >
> > -static int br_pass_frame_up_finish(struct sk_buff *skb)
> > -{
> > - netif_receive_skb(skb);
> > - return 0;
> > -}
> > -
> > static void br_pass_frame_up(struct net_bridge *br, struct sk_buff *skb)
> > {
> > struct net_device *indev;
> > @@ -38,7 +32,7 @@ static void br_pass_frame_up(struct net_
> > skb->dev = br->dev;
> >
> > NF_HOOK(PF_BRIDGE, NF_BR_LOCAL_IN, skb, indev, NULL,
> > - br_pass_frame_up_finish);
> > + netif_receive_skb);
>
> Are you certain the return values are compatible?
>
> Jeff
>
>
NF_HOOK(PF_BRIDGE, NF_BR_LOCAL_IN, skb, indev, NULL,
netif_receive_skb);
If you follow the expansion, the return value passed from the netfilter
hook is not used by netfilter, and the macro just propagates it out.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
