On Sun, Mar 12, 2006 at 01:41:13PM -0800, [EMAIL PROTECTED] wrote: > Not that my opinion should hold much weight, having been absent from the > driver for some time, but yuck. Is there no better way to do this thatn > sprinkling poo all over it?
The changes are mostly isolated into check_link(), the fact that half the function gets placed inside a conditional but diff sees it as a bunch of smaller changes makes the changes look a lot more invasive than they actually are. I guess that could be helped by splitting the PHY access code out of check_link() into check_phy_status() or something but I'm not sure how much that really helps. -- "You grabbed my hand and we fell into it, like a daydream - or a fever." - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
