----- Original Message -----
From: "Patrick McHardy" <[EMAIL PROTECTED]>
To: "Adrian Bunk" <[EMAIL PROTECTED]>
Cc: <netdev@vger.kernel.org>; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>; "Jing Min Zhao"
<[EMAIL PROTECTED]>; <linux-kernel@vger.kernel.org>
Sent: Thursday, March 23, 2006 9:02 PM
Subject: Re: Two comments on the H.323 conntrack/NAT helper
[The hotmail address of the author doesn't work, CCed sourceforge-address]
Adrian Bunk wrote:
Two comments on the H.323 conntrack/NAT helper:
- the function prototypes in ip_nat_helper_h323.c are _ugly_,
please move them to a header file
Their ugliness is because of the current API, which cleaned up
quite a lot of the surrounding code, but requires this ugliness
from each helper. I would like to keep them visible as a reminder
that a cleaner solution is wanted, but moving them to header
files certainly sound like a good idea to eliminate the risk
of prototype conflicts. But please do this for all helpers
at once.
- is there a reason for not using EXPORT_SYMBOL_GPL?
I would prefer that too.
I've moved those prototypes. But the move involves moving of two header files:
ip_conntrack_helper_h323_asn1.h and ip_conntrack_helper_h323_types.h.
This is because ip_conntrack_h323.h now has to include
ip_conntrack_helper_h323_asn1.h and thus ip_conntrack_helper_h323_types.h,
so they are moved from net/ipv4/netfilter/ to include/linux/netfilter_ipv4/ to
make sure other header files like ip_conntrack_h323.h and ip_conntrack.h
be able to find them.
Is this ok or you have a better idea?
Thanks a lot!
Jing Min Zhao
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
