From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 25 Mar 2006 16:42:56 +1100
> I was working on the ipip/xfrm problem and as usual I get side-tracked by > other problems. It is the nature of the game :-) > As part of an attempt to change the IPv4 protocol handler calling > convention I found that SCTP violated the existing convention. > > It's returning non-zero values after freeing the skb. This is doubly bad > as 1) the skb gets resubmitted; 2) the return value is interpreted as a > protocol number. > > This patch changes those return values to zero. > > IPv6 doesn't suffer from this problem because it uses a positive return > value as an indication for resubmission. So the only effect of this patch > there is to increment the IPSTATS_MIB_INDELIVERS counter which IMHO is > the right thing to do. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Good catch, applied. Thanks Herbert. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
