On Fri, Mar 31, 2006 at 09:14:45PM +1100, Herbert Xu wrote: > Hi: > > This patches merges the separate calls to le16_to_cpu and ntohl into one > swab32 call so that it is clear that we're simply changing a little-endian > value from the hardware to big-endian for the networking stack.
This defeats sparse endianes annotation (if e1000 had them which it should..). The right thing is to add be*_to_le* and le*_to_be* alias for swab* with the correct endianess annotations in byteorder.h and then use it. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
