A trivial patch to set `error' variable while not holding lock_sock(). Signed-off-by: Weongyo Jeong <weongyo.li...@gmail.com> --- net/ipv4/inet_connection_sock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index 6414891..58bc39f 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -306,14 +306,13 @@ struct sock *inet_csk_accept(struct sock *sk, int flags, int *err) struct request_sock_queue *queue = &icsk->icsk_accept_queue; struct request_sock *req; struct sock *newsk; - int error; + int error = -EINVAL; lock_sock(sk); /* We need to make sure that this socket is listening, * and that it has something pending. */ - error = -EINVAL; if (sk->sk_state != TCP_LISTEN) goto out_err; -- 2.1.3