Just a couple of very general comments:
- The kernel style is to avoid "//" comments like
> + //reset abyte_cnt and dummy_byte_cnt
please replace all of this with comments like
/* single-line comment */
or
/*
* multi-line comments
* look like this.
*/
- This driver looks like you are still in the middle of debugging it.
Please clean it up so you don't have commented out things such as
> + //temp |= (bit << (len - 1));
> + //printf("Data read: 0x%016llx\n",temp);
- Please try to use software to post your patches so that they end up
nicely threaded via In-Reply-To: headers. And also try to plan
ahead enough so that you don't end up things like "[PATCH 1.2/9]".
Finally, please try to give each patch in the series a brief
description in the Subject: line and a longer changelog entry in
the body of the email.
Doing all of this will make it much easier for you to get good review
comments and get your driver merged in the end.
Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
