On 03/24/2016 09:45 PM, Vijay Pandurangan wrote:
Actually, maybe they should be set to CHECKSUM_PARTIAL if we want veth to drop the packets if they have bad checksums before they hit the application level.
VETH is pretty special in that when you transmit a frame on one device, it's pair receives it, and unless there is RAM corruption or bugs in the kernel, then it cannot be corrupted. But, if you are routing frames from the network to veth devices, then the original packet could be corrupted, as described in your patch. Probably the right behaviour is to keep the old logic for packets originating from sockets, at least. I am not sure of a good way to implement that. As for testing, I am not sure. Probably you have to make a good effort and then just deal with fallout like what I found. I would guess that any of us who have ever written an interesting patch have also written an interesting bug! Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com
