On Sat, 2016-04-02 at 09:57 +0800, Herbert Xu wrote: > Eric Dumazet <eric.duma...@gmail.com> wrote: > > > > I do not particularly care, but it is worth mentioning that GRO+TSO > > would not be idempotent anymore. > > We could easily fix that by adding a feature bit to control this, > something like SKB_GSO_TCP_FIXEDID.
I understood the patch allowed to aggregate 4 segments having ID=12 ID=40 ID=80 ID=1000 -> resulting GRO packet with 4 segments and ID=12. TSO would generate 12,13,14,15 or 12,12,12,12 with your flag ? (Before the patch no aggregation took place and exact same packets were forwarded with 12, 40, 80, 1000) As I said, I am not sure we should care :)
