On 04/04/2016 09:35 AM, Johannes Berg wrote:
On Sat, 2016-04-02 at 23:38 -0700, Brenden Blanco wrote:
Having a common check makes sense. The tricky thing is that the type can
only be checked after taking the reference, and I wanted to keep the
scope of the prog brief in the case of errors. I would have to move the
bpf_prog_get logic into dev_change_bpf_fd and pass a bpf_prog * into the
ndo instead. Would that API look fine to you?
I can't really comment, I wasn't planning on using the API right now :)
However, what else is there that the driver could possibly do with the
FD, other than getting the bpf_prog?
A possible extension of this is just to keep the bpf_prog * in the
netdev itself and expose a feature flag from the driver rather than
an ndo. But that would mean another 8 bytes in the netdev.
That also misses the signal to the driver when the program is
set/removed, so I don't think that works. I'd argue it's not really
desirable anyway though since I wouldn't expect a majority of drivers
to start supporting this.
I think ndo is probably fine for this purpose, see also my other mail. I
think currently, the only really driver specific code would be to store
the prog pointer somewhere and to pass needed meta data to populate the
fake skb.
Maybe mid-term drivers might want to reuse this hook/signal for offloading
as well, not yet sure ... how would that relate to offloading of cls_bpf?
Should these be considered two different things (although from an offloading
perspective they are not really). _Conceptually_, XDP could also be seen
as a software offload for the facilities we support with cls_bpf et al.
Thanks,
Daniel
