On Sat, Apr 9, 2016 at 11:02 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Sat, 2016-04-09 at 10:36 -0700, Alexander Duyck wrote: > >> For next version I plan to include a check in netif_skb_features that >> will clear NETIF_F_TSO_MANGLEID if the DF bit is not set. > > So it looks like we slowly but surely make the whole stack damn slow, to > support some extra features. > > How many instructions are needed nowadays for netif_skb_features() > alone ? > > More than 120 if I am not mistaken, if we count fast path in > skb_network_protocol() > > Note: I have a patch to remove the gso_min_segs thing, currently unused. > > 2 instructions saved ! Woo-hoo !
I was planning to drop the checks for TSO_MANGLEID and GSO_PARTIAL in a if statment based on skb_is_gso() since I had both GSO_PARTIAL to check for as well. - Alex
