On 4/18/16, 7:22 PM, Eric Dumazet wrote: > On Mon, 2016-04-18 at 21:48 -0400, David Miller wrote: > >> And anyways, I get unaligned accesses without Roopa's changes :-/ >> >> davem@patience:~$ ip l l >> [3391066.656729] Kernel unaligned access at TPC[7d6c14] >> loopback_get_stats64+0x74/0xa0 >> [3391066.672020] Kernel unaligned access at TPC[7d6c18] >> loopback_get_stats64+0x78/0xa0 >> [3391066.687282] Kernel unaligned access at TPC[7d6c1c] >> loopback_get_stats64+0x7c/0xa0 >> [3391066.702573] Kernel unaligned access at TPC[7d6c20] >> loopback_get_stats64+0x80/0xa0 >> [3391066.717858] Kernel unaligned access at TPC[8609dc] >> dev_get_stats+0x3c/0xe0 > Yes, rtnl_fill_stats() probably has the same mistake. > > commit 550bce59baf3f3059cd4ae1e268f08f2d2cb1d5c > Author: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Fri Apr 15 20:36:25 2016 -0700 > > rtnetlink: rtnl_fill_stats: avoid an unnecssary stats copy > > This patch passes netlink attr data ptr directly to dev_get_stats > thus elimiating a stats copy. > > Suggested-by: David Miller <da...@davemloft.net> > Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> > Signed-off-by: David S. Miller <da...@davemloft.net> > > > David, if you revert the one in rtnl_fill_stats, i will take care of the dev_get_stats in RTM_GETSTATS in v6.
thanks, Roopa
