On 4/19/16, 11:31 AM, David Miller wrote: [snip] > > Here is the final patch I'm about to push out, thanks a lot Eric. > > Roopa, please adjust your GETSTATS patch as needed (I think you need > to adjust the SELinux table entry as well) and we can integrate that > too. ok, will do. one thing though, for GETSTATS, if I need a pad attribute like IFLA_PAD, I will need to add a new stats attribute IFLA_STATS_PAD and burn a bit for it in filter_mask too. In which case, I am wondering if we should live with the copy. I will take any suggestions here.
I had adjusted the SELinux table entries for v5. I will check again and make sure it is right for v6. > > ==================== > [PATCH] net: Align IFLA_STATS64 attributes properly on architectures that > need it. > > Since the nlattr header is 4 bytes in size, it can cause the netlink > attribute payload to not be 8-byte aligned. > > This is particularly troublesome for IFLA_STATS64 which contains 64-bit > statistic values. > > Solve this by creating a dummy IFLA_PAD attribute which has a payload > which is zero bytes in size. When HAVE_EFFICIENT_UNALIGNED_ACCESS is > false, we insert an IFLA_PAD attribute into the netlink response when > necessary such that the IFLA_STATS64 payload will be properly aligned. > > With help and suggestions from Eric Dumazet. > > Signed-off-by: David S. Miller <da...@davemloft.net> [snip] Thanks David.
