Sorry dropped the ball on this..

On 16-03-14 02:26 AM, Stephen Hemminger wrote:
On Wed,  9 Mar 2016 07:04:36 -0500
Jamal Hadi Salim <j...@mojatatu.com> wrote:


This code has diverged way from the general rule that ip utilities display
format should match the command format. For example the properties shown
on "ip route show" match those of "ip route add".


Valid point (and thanks for catching this since i tend to be the biggest
whiner  on this topic ;-> I will make the changes - doesnt seem to be
far off already.
Note: in ife case it may not always symetric because there are optional
fields which may be absent in a request to the kernel but present in
a response.

Also over the last several years, the code in iproute2 has switched from casting
RTA_DATA() everywhere to a cleaner interface rte_getattr_u32() more like what
is used in mnl library.


Will convert where it makes sense..

The code has also gotten deeply intended creating lots of lines that are too 
long.


Is this you or the script saying the above? How is the conclusion that
we have deep indentation come about?
I checked there are some code lines that are > 80 characters because
it doesnt make sense to break them down.

WARNING: 'doesnt' may be misspelled - perhaps 'doesn't'?
#21:

What, checking my spelling now? ;->
I am on the internets dude!

then provide a default so the user doesnt have to specify it.

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per 
line)
#25:
             "Distributing Linux Traffic Control Classifier-Action Subsystem"


75 character? ;-> What happened to 80?

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#143:
new file mode 100644

ERROR: "foo * bar" should be "foo *bar"


Will fix above and rest shortly.

Also, promise to send man page later. Ive coerced someone to do it;->

cheers,
jamal

Reply via email to