<faisal.la...@intel.com>, Doug Ledford <dledf...@redhat.com> Bcc: Subject: Re: [PATCH net] RDMA/nes: don't leak skb if carrier down Reply-To: l...@kernel.org In-Reply-To: <1461529139-28582-1-git-send-email...@strlen.de>
On Sun, Apr 24, 2016 at 10:18:59PM +0200, Florian Westphal wrote: > Alternatively one could free the skb, OTOH I don't think this test is > useful so just remove it. > > Cc: <linux-r...@vger.kernel.org> > Signed-off-by: Florian Westphal <f...@strlen.de> I don't know why did you decide to send it to netdev and not to relevant maintainers, but the relevant mailing list is linux-rdma and Faisal needs to Review/Acknowledge it. ➜ linux-rdma git:(master) ./scripts/get_maintainer.pl -f drivers/infiniband/hw/nes/nes_nic.c Faisal Latif <faisal.la...@intel.com> (supporter:NETEFFECT IWARP RNIC DRIVER (IW_NES)) Doug Ledford <dledf...@redhat.com> (supporter:INFINIBAND SUBSYSTEM) Sean Hefty <sean.he...@intel.com> (supporter:INFINIBAND SUBSYSTEM) Hal Rosenstock <hal.rosenst...@gmail.com> (supporter:INFINIBAND SUBSYSTEM) linux-r...@vger.kernel.org (open list:NETEFFECT IWARP RNIC DRIVER (IW_NES)) linux-ker...@vger.kernel.org (open list) > --- > Noticed this while working on the TX_LOCKED removal. > > diff --git a/drivers/infiniband/hw/nes/nes_nic.c > b/drivers/infiniband/hw/nes/nes_nic.c > index 3ea9e05..9291453 100644 > --- a/drivers/infiniband/hw/nes/nes_nic.c > +++ b/drivers/infiniband/hw/nes/nes_nic.c > @@ -500,9 +500,6 @@ static int nes_netdev_start_xmit(struct sk_buff *skb, > struct net_device *netdev) > * skb_shinfo(skb)->nr_frags, skb_is_gso(skb)); > */ > > - if (!netif_carrier_ok(netdev)) > - return NETDEV_TX_OK; > - > if (netif_queue_stopped(netdev)) > return NETDEV_TX_BUSY; > > -- > 2.7.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
signature.asc
Description: Digital signature
