On Wed, Apr 27, 2016 at 12:20 PM, David Miller <[email protected]> wrote: > From: Nicolas Dichtel <[email protected]> > Date: Fri, 22 Apr 2016 17:58:02 +0200 > >> The handler 'ila_fill_encap_info' adds one attribute: ILA_ATTR_LOCATOR. >> >> Fixes: 65d7ab8de582 ("net: Identifier Locator Addressing module") >> CC: Tom Herbert <[email protected]> >> Signed-off-by: Nicolas Dichtel <[email protected]> >> --- >> >> Tom, when I read the comment, I feel I'm misssing something, but what? > > Tom, seriously, please look at this. > Yes, it is an issue. Need to do add size for ILA_ATTR_LOCATOR and ILA_ATTR_CSUM_MODE. Also not we made ILA_ATTR_CSUM_MODE u64 in fill encap info. I will send a path shortly.
> And with recent changes in net-next the csum attribute size needs to > be specified as well, plus the locator needs to use the 64-bit > alignment sizing helper. Something other than nla_put_u64_64bit? Thanks, Tom
