On Sat, Apr 15, 2006 at 04:24:15PM +0200, Martin Diehl wrote: > > My only concern with this patch is this:
<..> > Hm, queue_work might fail (like it was possible with irda_queue_request), > if work->pending is set. In that case, chances are we have a partially > configured irda device dangling around. The idea was to (re-)enable rx and > restore the xmit queue state on netdev so we can rely on the upper layers > to recover. I think without the fallback the netdev might become unuseable > until ifdown/ifup-cycle, if queue_work would ever fail. queue_work doesn't fail if work->pending, it just noticed this particular work_Struct is already beeing serviced and tells you that. In the sir code that can't happen because the work_struct has ben allocated and initialized a few lines above, so there's zero chance for someone else to call queue_work on it concurrently. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
