Hi,
On 05/02/2016 09:39 PM, Hannes Frederic Sowa wrote:
> On 20.04.2016 10:19, Alexander Aring wrote:
>> This patch exports some neighbour discovery functions which can be used
>> by 6lowpan neighbour discovery ops functionality then.
>>
>> Cc: David S. Miller <da...@davemloft.net>
>> Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru>
>> Cc: James Morris <jmor...@namei.org>
>> Cc: Hideaki YOSHIFUJI <yoshf...@linux-ipv6.org>
>> Cc: Patrick McHardy <ka...@trash.net>
>> Signed-off-by: Alexander Aring <a...@pengutronix.de>
>> ---
>> include/net/ndisc.h | 16 ++++++++++++++++
>> net/ipv6/addrconf.c | 1 +
>> net/ipv6/ndisc.c | 28 ++++++++++------------------
>> 3 files changed, 27 insertions(+), 18 deletions(-)
>>
>> diff --git a/include/net/ndisc.h b/include/net/ndisc.h
>> index 14ed016..35a4396 100644
>> --- a/include/net/ndisc.h
>> +++ b/include/net/ndisc.h
>> @@ -53,6 +53,15 @@ enum {
>>
>> #include <net/neighbour.h>
>>
>> +/* Set to 3 to get tracing... */
>> +#define ND_DEBUG 1
>> +
>> +#define ND_PRINTK(val, level, fmt, ...) \
>> +do { \
>> + if (val <= ND_DEBUG) \
>> + net_##level##_ratelimited(fmt, ##__VA_ARGS__); \
>> +} while (0)
>> +
>
> If the debug messages are well thought out, I think we could install
> them always on debug level.
>
> There are valid users now, so
>
Not sure if I understand you correctly here. Is this patch is fine or I
should remove ND_DEBUG, because it's handled by "net_##level##_ratelimited"
and the debug level will be handled then by other debug level settings
then?
Thanks.
- Alex
