On Tue, Apr 18, 2006 at 02:54:16PM -0700, David S. Miller wrote: > > There are other areas of the packet which are interpreted in various > ways. For example, the martian source handling will dump the MAC > directly from skb->mac.raw into the kernel logs.
That's scary. I think this stuff needs an audit. > The output path is so much cleaner, because things like the protocol > are filled out in the struct flowi so there is no need to be parsing > the SKB in any way. Absolutely. I think we should put Stephen's patch in ASAP. Once the immediate problem is gone we can take our time and make the input path more like the output. At the end of this I'd like to see the skb argument from ip_route_input replaced by a dst_entry. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
