On 16-05-10 12:25 PM, Roopa Prabhu wrote:
On 5/9/16, 5:38 AM, Jamal Hadi Salim wrote:
Is it not possible to convert to 64b - and IFLA_STAT
becomes available just store it still in 64b?
i.e 32b will fit in 64b space.
The only problem is again if the last saved history file had 32 bit
and 32bit counters may roll over earlier.
I am not sure there is a good case of someone upgrading from 32b to 64b.
One more thing i am looking at right now which might work is using
the existing history file and use the info_source (aka header) in ifstat
history file to indicate
32bit or 64bit stats. For 32 bit it is currently "#kernel".
For 64 bit i plan to use "#kernel64".
Good idea.
If we are starting a new history file, i will always use 64bit and when using
an existing history file,
it will use 32bit.
And 64bit stats will be queried with RTM_GETSTATS if available or will use
IFLA_STATS64 when
RTM_NEWLINK Is used.
will see if i can get this working for all cases,
Yes, this would work.
Release it and see if someone is going to complain.
cheers,
jamal
