On 16.05.16 14:44, Andrew Lunn wrote: > On Mon, May 16, 2016 at 01:28:15PM +0200, Alexander Graf wrote: >> The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't >> enabled. >> It simply passes the device tree test, but leaves all internal configuration >> initialized at 0. Then it configures the phy with those values and renders a >> previously working configuration useless. >> >> This patch makes sure that we only build the DP83867 phy code when >> CONFIG_OF_MDIO is set, to not run into that problem. > > Hi Alexander > > Looking at the code, the parameters read from device tree are needed > for RGMII mode. What about the case the PHY is used not in RGMII mode? > Could it be there are device trees which legitimately don't have these > properties since they are not needed, and are now going to get > -ENODEV?
To be honest, I don't know. I only stumbled over this because we compile all those phy drivers as modules and the driver simply rendered one system I was working on unusable wrt network. Dan? Alex
