> -----Original Message----- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, June 6, 2016 9:41 AM > To: Limonciello, Mario <mario_limoncie...@dell.com> > Cc: hayesw...@realtek.com; LKML <linux-ker...@vger.kernel.org>; Netdev > <netdev@vger.kernel.org>; Linux USB <linux-...@vger.kernel.org>; > pali.ro...@gmail.com; anthony.w...@canonical.com; Greg KH > <gre...@linuxfoundation.org> > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > > + /* returns _AUXMAC_#AABBCCDDEEFF# */ > > + status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer); > > + obj = (union acpi_object *)buffer.pointer; > > + if (ACPI_SUCCESS(status)) { > > + if (obj->type != ACPI_TYPE_BUFFER || > > + obj->string.length != 0x17) { > > + pr_warn("r8152: get_passthru_addr: Invalid buffer"); > > Please don't use pr_warn() when you can use the better alternatives > like dev_warn(). > > Andrew
OK thanks, I'll adjust that to use a different warn.
