Mario Limonciello [mailto:mario_limoncie...@dell.com] [...] > + ret = hex2bin(buf, obj->string.pointer + 9, 6); > + if (ret < 0 || !is_valid_ether_addr(buf)) { > + netif_warn(tp, probe, tp->netdev, "Invalid MAC\n"); > + goto amacout; > + }
If hex2bin() is success, the ret would be 0. And you would return 0 when !is_valid_ether_addr(buf) occurs. I don't think it is what you wants. Best Regards, Hayes
