Hi Florian, Andrew,
Vivien Didelot <vivien.dide...@savoirfairelinux.com> writes:
> Hum reviewing that again, I see that if one of the 2 subsequent calls to
> request_irq fails, you end up with an unregistered MDIO bus.
>
> We have the same issue in the mv88e6xxx legacy probe code if dsa.c fails
> to allocate the dsa_switch structure. I'm moving the MDIO register code
> to the setup function like you are doing here (good idea!) to fix that.
In fact it doesn't fix the issue because dsa_switch_driver doesn't
provide any remove/teardown function, in which mv88e6xxx and sf2 could
unregister their MDIO bus on switch removal.
Would it be worth it to add such optional function to DSA drivers?
Thanks,
Vivien
