On Mon, Jun 13, 2016 at 11:41 AM, Jesse Gross <je...@kernel.org> wrote: > On Mon, Jun 13, 2016 at 10:48 AM, Alexander Duyck <adu...@mirantis.com> wrote: >> This change replaces the network device operations for adding or removing a >> VXLAN port with operations that are more generically defined to be used for >> any UDP offload port but provide a type. As such by just adding a line to >> verify that the offload type if VXLAN we can maintain the same >> functionality. >> >> Signed-off-by: Alexander Duyck <adu...@mirantis.com> > > It looks like bnxt actually has a hardcoded offload of the Geneve port > rather than using the registration (maybe it predated it?).
It's not hardcoded. The driver code just predated the ndo geneve calls. > It would > be nice to incorporate that into your unified handler as well. > > I think you could actually just kill all of these > CONFIG_VXLAN/CONFIG_GENEVE checks (across all the drivers, not just > this one). They shouldn't be necessary any more now that there's no > longer strong linkage to the tunnel drivers. Agreed.
