On Fri, Apr 28, 2006 at 02:57:31PM +0200, Ivo van Doorn wrote: > On Friday 28 April 2006 00:11, Christoph Hellwig wrote: > > On Fri, Apr 28, 2006 at 12:02:52AM +0200, Ivo van Doorn wrote: > > > From: Ivo van Doorn <[EMAIL PROTECTED]> > > > > > > Instead of dma_*_coherent > > > use pci_*consistent functions. > > > > No point in doing that, quite reverse as you use the gfp_mask argument > > which is a (small) pessimation here. > > Would it be recommended that I replace the usb_alloc_buffers in the > rt2570 driver with dma_*coherent? > This would get the dma rings allocation and freeing a bit more generic > between PCI and USB and could reduce some duplicate code between them. > But I am not sure if there is any major difference between the two.
I don't have the full code for your driver anywhere near me so I can't comment on this. Maybe you could send the code of 'usb_alloc_buffers' for comments? ---end quoted text--- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
