On Sat, Jun 18, 2016 at 2:34 AM, Eric Dumazet <eduma...@google.com> wrote: > On Fri, Jun 17, 2016 at 3:31 PM, Saeed Mahameed > <sae...@dev.mellanox.co.il> wrote: >> >> Today there are some bad usages and abuse to skb->protocol where some >> device drivers set skb->protocol = 0xffffff to skip the kernel TCP/IP >> processing for the same diagnostic purposes. >> In this series we are just trying to do the right thing. > > Well, your patch adds an extra test in kernel fast path, just to ease > the life of people using kernel bypass, > but willing to use tcpdump because they can not figure to do this in > user space properly. > > Please find a way _not_ adding a single instruction in kernel fast path. >
Well, we can set skb->protocol = 0xffff. what do you think ?
