On 16-06-19 11:14 PM, Roopa Prabhu wrote:
On Fri, Jun 17, 2016 at 10:12 AM, Florian Fainelli <f.faine...@gmail.com> wrote:
I have also mentioned this before, the default api must provide accumulated (hw and sw) stats..., because this is the api that the user queries on an interface.
Sorry - I missed those discussions. What is current practise? Do people request for one via ip link stats and the other via ethtool? What do you guys do in your implementation? Yes, it would be more accurate to provide aggregated stats but it may break backward compat if expectation is both are read separately today. Maybe it makes sense to have a brand new TLV for these aggregated stats as Jiri was suggesting.That means two new TLVs not one. 1) TLV for aggregated stats - which cant be current one 2) TLV for h/w stats The existing stat implies s/ware only. cheers, jamal