On 06/20/2016 08:20 AM, Rosen, Rami wrote:
> Hi all,
>
> A very limited review below.
>
> +
> + /* get capabilities of particular feature */
> + ENA_ADMIN_GET_FEATURE = 8,
>
> Instead /* get capabilities SHOULD BE: /* set capabilities .....
> +
> + /* get capabilities of particular feature */
> + ENA_ADMIN_SET_FEATURE = 9,
> +
> ..
>
>
> +int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)
> +{
> + struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;
> ...
>
> You set ret=-EINVAL, but you do not use this ret as you immediately return 0
> in the next line, which is the end of the method. Either return ret or return
> -EINVAL.
> + if (unlikely(ret)) {
> + ena_trc_err("Failed to set hash input. error: %d\n", ret);
> + ret = -EINVAL;
> + }
> +
> + return 0;
> +}
> +
I will return ret.
>
>
> +
> +/* ena_com_set_mmio_read_mode - Enable/disable the mmio reg read mechanism
> + * @ena_dev: ENA communication layer struct
>
>
> Instead realess_supported: SHOULD BE: readless_supported
ack
>
> + * @realess_supported: readless mode (enable/disable)
> + */
> +void ena_com_set_mmio_read_mode(struct ena_com_dev *ena_dev,
> + bool readless_supported);
> +
>
>
>
> +
> +/* ena_com_create_io_queue - Create io queue.
> + * @ena_dev: ENA communication layer struct
>
> Instead ena_com_create_io_ctx SHOULD BE: @ena_com_create_io_ctx
ack
>
> + * ena_com_create_io_ctx - create context structure
> + *
> + * Create the submission and the completion queues.
> + *
> + * @return - 0 on success, negative value on failure.
> + */
> +int ena_com_create_io_queue(struct ena_com_dev *ena_dev,
> + struct ena_com_create_io_ctx *ctx);
> +
>
>
>
>
> +/* ena_com_admin_destroy - Destroy IO queue with the queue id - qid.
> + * @ena_dev: ENA communication layer struct
>
> Missing: @qid
ack
>
> + */
> +void ena_com_destroy_io_queue(struct ena_com_dev *ena_dev, u16 qid);
> +
>
> Regards,
> Rami Rosen
> Intel Corporation
Thanks for the review
