On Thu, Jun 23, 2016 at 4:04 AM, Wang Sheng-Hui <shh...@foxmail.com> wrote:
> Fixes: 311c7c71c9bb ("net/mlx5e: Allocate DMA coherent memory on
> reader NUMA node")
>Hi Wang, I am sorry for the nitpicking, but the commit message needs to be improved. I prefer putting the "Fixes" line only after the bug description (commit message) just before the Signed-of-by line. you can find some examples in the commit log history. > > Change since V1: > * Add Fixes line in commit log > This should come only after the "---" below so it won't appear in the commit log. http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb > Signed-off-by: Wang Sheng-Hui <shh...@foxmail.com> > --- ["Changes since" goes here] > drivers/net/ethernet/mellanox/mlx5/core/wq.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > Thanks, Saeed
