On Thu, Jun 23, 2016 at 8:27 AM, Leon Romanovsky <leo...@mellanox.com> wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: >> The logging macros create a bit of duplicated code/text. >> >> Use specialized functions to reduce the duplication. >> >> (defconfig/x86-64) >> $ size drivers/net/ethernet/mellanox/mlx5/core/built-in.o* >> text data bss dec hex filename >> 178634 2059 16 180709 2c1e5 >> drivers/net/ethernet/mellanox/mlx5/core/built-in.o.new >> 188679 2059 16 190754 2e922 >> drivers/net/ethernet/mellanox/mlx5/core/built-in.o.old >> >> The output changes now do not include line #, >> but do include the function offset. >> >> Signed-off-by: Joe Perches <j...@perches.com> > > As far as I see all these functions are used in error paths, so no > implication on performance is expected. > > And I'm fine with function offsets. > > Saeed, > What do you think?
Fine with me, need to fix my comment on functions placement, an your comment on checkpatch.
