On Wed, Jul 20, 2016 at 11:07:57AM +0200, Daniel Borkmann wrote: > On 07/19/2016 09:16 PM, Brenden Blanco wrote: [...] > >+ if (ring->xdp_prog) > >+ bpf_prog_put(ring->xdp_prog); > > Would be good if you also make this a READ_ONCE() here. I believe this is the > only other spot in your set that has this 'direct' access (besides xchg() and > READ_ONCE() from mlx4_en_process_rx_cq()). It would be mostly for consistency > and to indicate that there's a more complex synchronization behind it. I'm > mostly > worried that if it's not consistently used, people might copy this and not use > the READ_ONCE() also in other spots where it matters, and thus add hard to > find > bugs. I can do that. My thinking was just that this is the cleanup path so the code would have been superfluous. I think there were a few nits so I'll collect those and clean them up. > [...]
- Re: [PATCH v10 01/12] bpf: add bpf_prog_add ap... Alexei Starovoitov
- [PATCH v10 08/12] bpf: add XDP_TX xdp_action for di... Brenden Blanco
- Re: [PATCH v10 08/12] bpf: add XDP_TX xdp_acti... Alexei Starovoitov
- [PATCH v10 07/12] net/mlx4_en: add page recycle to ... Brenden Blanco
- Re: [PATCH v10 07/12] net/mlx4_en: add page re... Alexei Starovoitov
- [PATCH v10 06/12] Add sample for adding simple drop... Brenden Blanco
- Re: [PATCH v10 06/12] Add sample for adding si... Alexei Starovoitov
- [PATCH v10 05/12] net/mlx4_en: add support for fast... Brenden Blanco
- Re: [PATCH v10 05/12] net/mlx4_en: add support... Alexei Starovoitov
- Re: [PATCH v10 05/12] net/mlx4_en: add support... Daniel Borkmann
- Re: [PATCH v10 05/12] net/mlx4_en: add sup... Brenden Blanco
- Re: [PATCH v10 05/12] net/mlx4_en: add support... Jesper Dangaard Brouer
- Re: [PATCH v10 05/12] net/mlx4_en: add support... Tom Herbert
- Re: [PATCH v10 05/12] net/mlx4_en: add sup... Daniel Borkmann
- Re: [PATCH v10 00/12] Add driver bpf hook for early... David Miller
- Re: [PATCH v10 00/12] Add driver bpf hook for ... Brenden Blanco
- Re: [PATCH v10 00/12] Add driver bpf hook for ... David Miller