On Fri, Jul 22, 2016 at 08:04:50AM +0300, Julian Anastasov wrote: > > Hello, > > On Fri, 22 Jul 2016, f...@ikuai8.com.aqb.so wrote: > > > From: Gao Feng <f...@ikuai8.com> > > > > This minor refactoring does not change the logic of function > > ip_vs_genl_dump_dests. > > > > Signed-off-by: Gao Feng <f...@ikuai8.com> > > Looks good to me, > > Acked-by: Julian Anastasov <j...@ssi.bg> > > If there is a next version you can change above > "lvs" with "ipvs" in the Subject, this is the name we use > for the kernel part.
No need to repost just to fix that, I can fix it up when queuing up the patch. > > > --- > > v1: Initial patch > > > > net/netfilter/ipvs/ip_vs_ctl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c > > index c3c809b..6dc86cc 100644 > > --- a/net/netfilter/ipvs/ip_vs_ctl.c > > +++ b/net/netfilter/ipvs/ip_vs_ctl.c > > @@ -3267,7 +3267,7 @@ static int ip_vs_genl_dump_dests(struct sk_buff *skb, > > > > > > svc = ip_vs_genl_find_service(ipvs, attrs[IPVS_CMD_ATTR_SERVICE]); > > - if (IS_ERR(svc) || svc == NULL) > > + if (IS_ERR_OR_NULL(svc)) > > goto out_err; > > > > /* Dump the destinations */ > > -- > > 1.9.1 > > Regards > > -- > Julian Anastasov <j...@ssi.bg> >
