On 8/8/16 10:24 AM, Lorenzo Colitti wrote: > On Tue, Aug 9, 2016 at 12:27 AM, David Ahern <d...@cumulusnetworks.com> wrote: >>> - if (!fl6.flowi6_oif && ipv6_addr_is_multicast(&fl6.daddr)) >>> - fl6.flowi6_oif = np->mcast_oif; >>> - else if (!fl6.flowi6_oif) >>> - fl6.flowi6_oif = np->ucast_oif; >>> - >> >> That code removal is contrary to your patch description regarding flowi6_oif. > > Which code removal? The one I quote above? That code wasn't removed, > it was moved to above the initialization of flowi6. >
Your description states: "ping_v6_sendmsg never sets flowi6_oif, so it is not possible to ping an IPv6 address on a different interface." That code snippet above contradicts that -- flowi6_oif is set in ping_v6_sendmsg. You are making a different change than just setting flowi6_oif.
