On Fri, 2016-08-12 at 11:20 -0700, Raghu Vatsavayi wrote:
> Consolidate common functionality of various devices
> from different files into lio_core.c/octeon_console.c.
trivial notes:
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c
> b/drivers/net/ethernet/cavium/liquidio/lio_core.c
[]
> +void liquidio_link_ctrl_cmd_completion(void *nctrl_ptr)
> +{
[]
> + case OCTNET_CMD_CHANGE_MACADDR:
> + mac = ((u8 *)&nctrl->udd[0]) + 2;
> + netif_info(lio, probe, lio->netdev,
> + "MACAddr changed to
> %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x\n",
"MACAddr changed to %pM\n", mac);
[]
> + case OCTNET_CMD_TNL_RX_CSUM_CTL:
> + if (nctrl->ncmd.s.param1 == OCTNET_CMD_RXCSUM_ENABLE) {
> + netif_info(lio, probe, lio->netdev,
> + "%s RX Checksum Offload Enabled\n",
> + netdev->name);
> + } else if (nctrl->ncmd.s.param1 ==
> + OCTNET_CMD_RXCSUM_DISABLE) {
> + netif_info(lio, probe, lio->netdev,
> + "%s RX Checksum Offload Disabled\n",
> + netdev->name);
Aren't these a bit redundant output with the both name
output of lio->netdev->name and netdev->name?
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
[]
> @@ -297,11 +297,10 @@ lio_get_eeprom(struct net_device *netdev, struct
> ethtool_eeprom *eeprom,
>
> eeprom->magic = oct_dev->pci_dev->vendor;
> board_info = (struct octeon_board_info *)(&oct_dev->boardinfo);
> - len =
> - sprintf((char *)bytes,
> - "boardname:%s serialnum:%s maj:%lld min:%lld\n",
> - board_info->name, board_info->serial_number,
> - board_info->major, board_info->minor);
> + len = sprintf((char *)bytes,
> + "boardname:%s serialnum:%s maj:%lld min:%lld\n",
> + board_info->name, board_info->serial_number,
> + board_info->major, board_info->minor);
snprintf might be better and len doesn't seem useful here
> return 0;
> }
