On Fri, 12 May 2006 16:35:27 -0400, Michael Wu wrote: > Hm, so why not add something that will tell you what modes are supported by > the hardware?
Sounds reasonable. > Only problem with this patch is if the hardware adds any modes after > registration, they will be disabled initially. Hopefully, no drivers will > actually need to do that. bcm43xx does that. If I understand it correctly, bcm43xx driver doesn't know allowed modes until it loads firmware. And the firmware is not loaded until the device is opened (they probably have a reason for this). This issue can be easily solved by not masking hw_modes by valid_hw_modes in ieee80211_ioctl_prism2_param and ieee80211_precalc_modes. Just check (hw_modes & valid_hw_modes) instead of hw_modes in ieee80211_sta_scan_timer. And yes, hw_modes is a confusing name. It should be named hw_modes_mask_disabled_by_user or so. Maybe at least some better comment about this in ieee80211_i.h won't be a bad idea. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
