On Thu, 18 Aug 2016, Cong Wang wrote: > Doesn't this mean we can now just remove the ingress case from > tc_dump_qdisc() and simply iterate the whole hash table?
That'd be indeed a nice cleanup, but for that we'll have to make sure that the top-level ingress entry makes it to the hashtable as well; that's not the case currently, and hence the special-casing (but I agree that it's in principle just a remnant of the old design and of a rather 1:1 list->hashtable conversion, and there is no good reason for keeping it this way any more). So patch that'd add ingress qdisc to the hashtable whenever it materializes should be enough to get rid of the "we have to walk two linked lists" heritage and the ingress special-casing for dumps. Will look into it next week unless someone is faster. Thanks, -- Jiri Kosina SUSE Labs
